Code review
Submitted by saurabh on Fri, 2007-05-04 12:14
This page contains observations noted down during the code review.
- Complete code review of MercE source.
- Important code reviews which are pending:
- mailcheck - utility to control working of various mail related services.
- mailbackup - utility which archives mails of mailbac on a monthly basis.
- Netconfig.sh - all the pid files, configuration files, /etc/init.d files, basic commands should have their paths in Netconfig.sh
- ldap based codes - discuss the new schema, freeze it and incorporate the new schema which will be decided.
- fetchmail UI and backend.
- groups UI.
- merce_permissions - was created for SLES 10 2.6.0 because SusEconfig internally uses chkstat which changes ownership, permissions in the format "filepath user.group permission_bits". It does not touch symlinks and does not set setuid permissions on an insecure path like /opt/merce/bin. This part was circumvented by creating a shell script which carries out the same function as chkstat but by using explicit chown, chmod calls. Discuss and decide what to do about this.
- Review of all permission files for duplication, wrong permissions/ownership.
»
- Login to post comments
- Printer-friendly version
- Send to friend